Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#100] Prevent code duplication by using a Taskfile #102

Merged
merged 1 commit into from
Oct 29, 2024
Merged

fix: [#100] Prevent code duplication by using a Taskfile #102

merged 1 commit into from
Oct 29, 2024

Conversation

sbp-bvanb
Copy link
Collaborator

@sbp-bvanb sbp-bvanb commented Oct 28, 2024 •
edited
Loading

  • Phase out src/go-test.sh in favor of a Taskfile to prevent code duplication across multiple Golang repositories.
  • Add E2e support.
  • Run the same go commands locally and remotely.
  • Resolve documentation issue in README regarding the use of GITHUB_TOKEN.

@sbp-bvanb sbp-bvanb linked an issue Oct 28, 2024 that may be closed by this pull request
Run the same go commands everywhere #100
Closed
@sbp-bvanb sbp-bvanb force-pushed the 100-remote-taskfile branch 29 times, most recently from f4b2e26 to 045b2e0 Compare October 28, 2024 21:04
@sbp-bvanb sbp-bvanb force-pushed the 100-remote-taskfile branch 12 times, most recently from d15a91a to 46978b8 Compare October 29, 2024 10:28
@sbp-bvanb sbp-bvanb linked an issue Oct 29, 2024 that may be closed by this pull request
Run E2E tests #66
Closed
@sbp-bvanb sbp-bvanb force-pushed the 100-remote-taskfile branch from 46978b8 to e754069 Compare October 29, 2024 13:14
@sbp-bvanb sbp-bvanb linked an issue Oct 29, 2024 that may be closed by this pull request
Typo in readme: action does not push #101
Closed
@sbp-bvanb sbp-bvanb force-pushed the 100-remote-taskfile branch from e754069 to 0797f82 Compare October 29, 2024 13:19
@sbp-bvanb sbp-bvanb force-pushed the 100-remote-taskfile branch from 0797f82 to f751ffb Compare October 29, 2024 14:09
@sbp-bvanb sbp-bvanb merged commit f100ea4 into main Oct 29, 2024
1 check passed
@sbp-bvanb sbp-bvanb deleted the 100-remote-taskfile branch October 29, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jherrerasbp jherrerasbp jherrerasbp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in readme: action does not push Run the same go commands everywhere Run E2E tests
2 participants
@sbp-bvanb @jherrerasbp